Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an option in the deployments to use NUMA Aware scheduler #28

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

manurodriguez
Copy link
Collaborator

@manurodriguez manurodriguez commented Dec 8, 2023

build-depends: rh-nfv-int/nfv-example-cnf-deploy#43

a variable numa_aware_topology can be used to define the NUMA aware scheduler.

a variable numa_aware_topology can be used to define the
NUMA aware scheduler.
@manurodriguez manurodriguez self-assigned this Dec 8, 2023
@dcibot
Copy link

dcibot commented Dec 8, 2023

ERROR Unable to start a job on distributed-ci.io: Unable to find cluster1 pipeline

@dcibot
Copy link

dcibot commented Dec 8, 2023

@manurodriguez manurodriguez changed the title add an option in the deployments to use NUMA Aware scheduler [WIP] add an option in the deployments to use NUMA Aware scheduler Dec 8, 2023
@capolrik
Copy link
Collaborator

It's a bit tricky here.
If I understood correctly, example-cnf uses CustomResource to deploy testpmd and trex pods. The deployment you modified is meant for the operators which manages these resources. But I am not sure of this as I did not identify clearly what part of the code can deployed the testpmd and trex pods.

@tkrishtop
Copy link
Collaborator

hi @manurodriguez I'll check the images you create after the daily, I believe you hit a build issue here

@capolrik
Copy link
Collaborator

You can check the tag of the images generated in Quay: https://quay.io/organization/rh-nfv-int
I believe, the testpmd operator and Trex operator used the updated images.

@manurodriguez manurodriguez changed the title [WIP] add an option in the deployments to use NUMA Aware scheduler add an option in the deployments to use NUMA Aware scheduler Dec 11, 2023
@tkrishtop
Copy link
Collaborator

You can check the tag of the images generated in Quay: https://quay.io/organization/rh-nfv-int I believe, the testpmd operator and Trex operator used the updated images.

let's also validate that the new deployment is present in this new image

$ podman cp $(podman create --rm quay.io/bla-bla/image bash):/manifests .
$ cat manifests/deployment.yml

Copy link
Collaborator

@tkrishtop tkrishtop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@tonyskapunk tonyskapunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@manurodriguez
Copy link
Collaborator Author

Thanks

@manurodriguez manurodriguez merged commit 886ca6e into main Dec 12, 2023
@manurodriguez manurodriguez deleted the add-numa-scheduler branch December 12, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants