Fix for lifecycle postStart and preStop tests - excepting cnf-app-mac-operator #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramperher
changed the title
|
In this job, you can see the lifecycle-container-startup/shutdown tests are now passing, and the rest of tests remain in the same status, so this is ready for review. |
ramperher
changed the title
|
Let's wait for confirmation from tnf regarding the issue we have with cnf-app-mac-operator, just to know if it's a hard requirement to have a shell for running commands. |
|
I've decided not to change cnf-app-mac-operator in this PR, I'll address it in a separate change. The changes for the other operators are correct and this can be merged. @capolrik @tkrishtop could anyone of you please take a look to the change to have it merged? |
ramperher
changed the title
tkrishtop
reviewed
Jan 4, 2024
|
This change will be used to integrate the fix for cnf-app-mac-operator: #35. In the meanwhile, this PR can be merged safely. |
tkrishtop
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cnf-app-mac-operator case will be addressed in a separate change.