-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt cnf-app-mac-operator to operator-sdk v1.33.0 #55
Conversation
ramperher
commented
Feb 14, 2024
•
edited
Loading
edited
- Created new cnf-app-mac-operator folder and creating operator-sdk v1.33.0 skeleton with the commands included in README
- Rest of the work was mainly to move missed files to the project, check all files created, adapt Makefile to the new structure, and adapt Golang code to new controller-runtime version used
- webserver is no longer needed for cnf-app-mac-operator controller-manager since it now includes healthz endpoint, so reusing it
- main.go is now under cmd/main.go
- controllers folder is now under internal/controller
1f7d25c
to
c6c5829
Compare
c6c5829
to
d7920a7
Compare
I've launched this job and it has passed the installation of example-cnf, now it's running preflight: https://www.distributed-ci.io/jobs/dbdfc0b4-00e4-4316-b511-c3963935ae6b/jobStates?sort=date. Change can be reviewed in the meantime. |
from change #55: |
Change is working and example-cnf execution and certification looks good, this is ready for review. Again, similarly to the testpmd-lb-operator, most changes are because of refactoring made by operator-sdk v1.33.0. |
d7920a7
to
8b780d3
Compare
I've just rebased after merging #53, change is ready for review, no more tests are expected to be launched |
PR build check failed, probably because the new images for example-cnf latest versions are still being built in #53, I'll relaunch after some minutes (upd. fixed) |
8b780d3
to
34f209f
Compare
Just making a change in the README, no more debug tests are needed for the moment, waiting for reviews. |
I'll wait till tomorrow EOB to receive any more feedback, else I will merge it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM