Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove not used Python code from listener image #58

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Remove not used Python code from listener image #58

merged 1 commit into from
Feb 19, 2024

Conversation

ramperher
Copy link
Collaborator

@ramperher ramperher commented Feb 19, 2024 •
edited
Loading

This code is not used, let's clean it to reduce technical debt

@dcibot
Copy link

dcibot commented Feb 19, 2024

from change #58:

@ramperher
Copy link
Collaborator Author

Change is ready for review, effectively it's working as expected since the removed code is not used in the current version.

tkrishtop
tkrishtop approved these changes Feb 19, 2024
View reviewed changes
Copy link
Collaborator

@tkrishtop tkrishtop left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I do not see these logs anywhere with zgrep -a "fetch completed" * on the daily example-cnf

@ramperher ramperher merged commit 570784d into main Feb 19, 2024
1 check passed
@tonyskapunk tonyskapunk deleted the clean-lb-listener branch November 20, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkrishtop tkrishtop tkrishtop approved these changes

@capolrik capolrik Awaiting requested review from capolrik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ramperher @dcibot @tkrishtop