Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code #60

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Remove unused code #60

merged 1 commit into from
Mar 5, 2024

Conversation

ramperher
Copy link
Collaborator

@ramperher ramperher commented Mar 1, 2024

build-depends: rh-nfv-int/nfv-example-cnf-deploy#51

This code is legacy one that is no longer used:

  • cnf-app-mac-fetch (cnf-app-mac-operator) - we still have references to this : https://github.com/rh-nfv-int/cnf-app-mac-fetch, but in fact, the current cnf-app-mac-operator is the evolution of that code, we no longer need this
  • cnf-run configmap (testpmd-operator) - even though this file is loaded by using a configmap, we never use it; we rely on the Python scripts provided in the testpmd image

@dcibot
Copy link

dcibot commented Mar 1, 2024

@ramperher
Copy link
Collaborator Author

Check is working, the removed code is not affecting, this is ready for review

Copy link
Collaborator

@manurodriguez manurodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ramperher ramperher merged commit 16fc479 into main Mar 5, 2024
1 check passed
@tonyskapunk tonyskapunk deleted the remove-unused-code branch November 20, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants