Update securityContext fields of testing pods for runAsNonRoot user check #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramperher
force-pushed
the
certsuite-security-context-updates
branch
from
16c1fb3 to
b744293
Compare
ramperher
force-pushed
the
certsuite-security-context-updates
branch
from
b744293 to
146e21f
Compare
ramperher
force-pushed
the
certsuite-security-context-updates
branch
2 times, most recently
from
88da63b to
c4fb909
Compare
ramperher
force-pushed
the
certsuite-security-context-updates
branch
from
c4fb909 to
f66a309
Compare
ramperher
force-pushed
the
certsuite-security-context-updates
branch
from
f66a309 to
9a82c40
Compare
ramperher
changed the title
|
Change is ready for review, the job was passing. I've finally updated the PR to just cover access-control-security-context-run-as-non-root-user-check test, I'll address the read-only test in a different PR since that deserves more investigation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to what was done for #80 in controller-manager, now this is required for pods under test too. Addressing the following test cases:
I've added readOnly feature as commented, just to test it in a separate PR, so that we will address access-control-security-context-read-only-file-system test