-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use readOnlyRootFilesystem securityContext in data plane pods #96
Conversation
8d6cd7a
to
7d2e05c
Compare
from change #96: |
9989411
to
b9b31ee
Compare
from change #96: |
from change #96: |
Up to now, testpmd is working but trex is failing. By checking the logs, I've seen the same issue I saw in testpmd logs, complaining about /var/run/dpdk folder:
So I'll add a volume also in that folder. |
b9b31ee
to
4ee46b6
Compare
from change #96: |
4ee46b6
to
9180b71
Compare
from change #96: |
Testing is finished, now the data plane pods are passing this test related to readOnlyRootFilesystem feature, while testpmd is behaving correctly and the result in terms of performance is the same. I've created this change in dallas-pipelines to reflect this update: https://github.com/dci-labs/dallas-pipelines/pull/1259 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -31,7 +31,7 @@ port_obj_l2_template = { | |||
"src_mac": "" | |||
} | |||
|
|||
CFG_FILE = "/etc/trex_cfg.yaml" | |||
CFG_FILE = "/usr/local/bin/example-cnf/trex_cfg.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, just for my understanding, I'm curious why you decided to move the trex cfg file to /usr/local/bin/example-cnf/
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because, if leaving it at /etc/
, I would have needed to mount a volume on /etc
folder to be able to create that file, and I didn't want to expose the whole /etc
directory just for that
Tests: