Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix provisioning status for hw configuration #560

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Missxiaoguo
Copy link
Collaborator

Description:

  • For cases where the Configured condition is not yet present in the NodePool, but hardware configuration updates have occurred, requeue to wait for the NodePool to be processed.
  • Set hardware provisioning startTime after the NodePool is created, and hardware configuration startTime after the NodePool is updated. This helps distinguish between cases where no hardware updates were requested and cases where updates were made but the NodePool hasn’t been processed yet (i.e., the Configured condition hasn’t been returned).
  • Set the HardwareProvisioned and HardwareConfigured conditions, along with the provisioningPhase, to “Waiting for NodePool (name) to be processed” when the Provisioned or Configured condition is not yet present in the NodePool.
  • Add retries for some essential resource queries.
  • Add unittests for hw configuration.

For cases where the Configured condition is not yet
present in the NodePool, but there was hw configuration
updates have occurred, requeue to wait for the NodePool
to be processed.

Signed-off-by: Angie Wang <[email protected]>
Copy link

openshift-ci bot commented Feb 12, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from missxiaoguo. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Missxiaoguo
Copy link
Collaborator Author

Tested provisioning and configuration with hw lookback adaptor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant