Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Red Hat Konflux update telco-core-rds-4-19 #90

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

red-hat-konflux[bot]
Copy link

Pipelines as Code configuration proposal

To start the PipelineRun, add a new comment with content /ok-to-test

For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun

To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

@openshift-ci openshift-ci bot requested review from yanirq and yuvalk January 13, 2025 18:38
Copy link

openshift-ci bot commented Jan 13, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: red-hat-konflux[bot]
Once this PR has been reviewed and has the lgtm label, please assign marsik for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Jan 13, 2025

Hi @red-hat-konflux[bot]. Thanks for your PR.

I'm waiting for a openshift-kni member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 13, 2025
@yanirq
Copy link
Member

yanirq commented Jan 13, 2025

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 13, 2025
@rbaturov
Copy link
Contributor

rbaturov commented Jan 19, 2025

/hold
Depends on: #92

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 19, 2025
@rbaturov
Copy link
Contributor

/unhold
We can update this dockerfile after we integrate konflux

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2025
@yanirq
Copy link
Member

yanirq commented Jan 30, 2025

@rbaturov is this still relevant or do we have a new overriding PR coming in ?

@rbaturov
Copy link
Contributor

@rbaturov is this still relevant or do we have a new overriding PR coming in ?

Still relevant

@rbaturov
Copy link
Contributor

rbaturov commented Feb 5, 2025

/retest

@yanirq
Copy link
Member

yanirq commented Feb 5, 2025

/lgtm

/cc @MarSik

@openshift-ci openshift-ci bot requested a review from MarSik February 5, 2025 15:12
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2025
@rbaturov
Copy link
Contributor

rbaturov commented Feb 6, 2025

/hold
Lets wait with it, as we might redesign the way we deploy our konflux components, as there is ongoing discussion to possibly not using the ProjectDevelopmentStreamTemplate

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 6, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2025
Copy link

openshift-ci bot commented Feb 6, 2025

New changes are detected. LGTM label has been removed.

red-hat-konflux added 3 commits February 6, 2025 15:38
@yuvalk yuvalk removed their request for review February 7, 2025 19:06
red-hat-konflux added 2 commits February 10, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants