for single component applications keep the contexts as pull_request #48
+33
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pramod Bindal <[email protected]>
| @@ -349,8 +349,14 @@ func generateKonflux(application k.Application, target string) error { | |||
| if err := generateFileFromTemplate("application.yaml", application, filepath.Join(target, application.Version, "application.yaml")); err != nil { | |||
| return err | |||
| } | |||
| if err := generateFileFromTemplate("tests.yaml", application, filepath.Join(target, application.Version, "tests.yaml")); err != nil { | |||
| return err | |||
| if len(application.Components) == 1 { | |||
There was a problem hiding this comment.
even for multiple components for pull_request i don't see EC running sometime
ex: openshift-pipelines/tektoncd-pipeline#278
There was a problem hiding this comment.
lets keep the PR open for some time.
As this PR is merged so there is no much data. we will try to find some other PR where EC not triggered and then check their configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.