Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e for manualapprovalgate and chains #1340

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add e2e for manualapprovalgate and chains #1340

wants to merge 3 commits into from

Conversation

pramodbindal
Copy link
Contributor

Add e2e for manualapprovalgate

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pramodbindal
Once this PR has been reviewed and has the lgtm label, please assign ppitonak for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pramodbindal pramodbindal changed the title Add e2e for manualapprovalgate Add e2e for manualapprovalgate and chains Jan 20, 2025
@pramodbindal pramodbindal mentioned this pull request Jan 20, 2025
Closed
savitaashture
savitaashture reviewed Jan 21, 2025
View reviewed changes
.konflux/tekton/bundle-e2e-pipeline.yaml
- name: CHAINS_DOCKER_CONFIG_JSON
valueFrom:
secretKeyRef:
key: config.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where do we create this secret ??

savitaashture
savitaashture reviewed Jan 21, 2025
View reviewed changes
.konflux/tekton/bundle-e2e-pipeline.yaml
script: |

export CHAINS_REPOSITORY=quay.io/openshift-pipeline/chainstest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this another quay repository ?? is chainstest already created under openshift-pipeline ??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this repo is being used in plumbing repo for release tests. so consistency I am using the same repo here.

And Yes this repo exists
https://quay.io/repository/openshift-pipeline/chainstest?tab=tags&tag=latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savitaashture savitaashture savitaashture left review comments

@openshift-pipelines-bot openshift-pipelines-bot Awaiting requested review from openshift-pipelines-bot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pramodbindal @savitaashture