Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate openshift/custom-resource-status dependency #2552

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

2uasimojo
Copy link
Member

@2uasimojo 2uasimojo commented Jan 28, 2025

openshift/custom-resource-status has been bit-rotting, and its functionality is available upstream in apimachinery. Replace.

NOTE: This entails swapping out the type of
ClusterDeploymentCustomization.Status.Conditions from c-r-s to apimachinery/.../meta/v1. While these types are slightly different, we were only using the common subset of their fields, and those fields should marshal/unmarshal the same.

HIVE-2754

openshift/custom-resource-status has been bit-rotting, and its
functionality is available upstream in apimachinery. Replace.

NOTE: This entails swapping out the type of
ClusterDeploymentCustomization.Status.Conditions from c-r-s to
apimachinery/.../meta/v1. While these types are slightly different, we
were only using the common subset of their fields, and those fields
*should* marshal/unmarshal the same.

HIVE-2754
@openshift-ci openshift-ci bot requested review from dlom and suhanime January 28, 2025 22:29
Copy link
Contributor

openshift-ci bot commented Jan 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2025
@2uasimojo
Copy link
Member Author

/hold for testing

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 28, 2025
Copy link
Contributor

openshift-ci bot commented Jan 29, 2025

@2uasimojo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.78%. Comparing base (ec3bc72) to head (d75930a).
Report is 7 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2552   +/-   ##
=======================================
  Coverage   49.78%   49.78%           
=======================================
  Files         281      281           
  Lines       33029    33029           
=======================================
  Hits        16444    16444           
  Misses      15252    15252           
  Partials     1333     1333           
Files with missing lines Coverage Δ
.../clusterdeployment/clusterdeployment_controller.go 67.03% <100.00%> (ø)
pkg/controller/clusterpool/collections.go 75.57% <100.00%> (ø)
pkg/test/assert/assertions.go 90.00% <100.00%> (ø)
...entcustomization/clusterdeploymentcustomization.go 92.20% <100.00%> (ø)
...is/hive/v1/clusterdeploymentcustomization_types.go 0.00% <ø> (ø)

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 7, 2025
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants