-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate openshift/custom-resource-status dependency #2552
base: master
Are you sure you want to change the base?
Conversation
openshift/custom-resource-status has been bit-rotting, and its functionality is available upstream in apimachinery. Replace. NOTE: This entails swapping out the type of ClusterDeploymentCustomization.Status.Conditions from c-r-s to apimachinery/.../meta/v1. While these types are slightly different, we were only using the common subset of their fields, and those fields *should* marshal/unmarshal the same. HIVE-2754
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 2uasimojo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold for testing |
@2uasimojo: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2552 +/- ##
=======================================
Coverage 49.78% 49.78%
=======================================
Files 281 281
Lines 33029 33029
=======================================
Hits 16444 16444
Misses 15252 15252
Partials 1333 1333
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift/custom-resource-status has been bit-rotting, and its functionality is available upstream in apimachinery. Replace.
NOTE: This entails swapping out the type of
ClusterDeploymentCustomization.Status.Conditions from c-r-s to apimachinery/.../meta/v1. While these types are slightly different, we were only using the common subset of their fields, and those fields should marshal/unmarshal the same.
HIVE-2754