Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing import file extensions, add @TODO comments for refactoring #582

Merged
merged 1 commit into from
Mar 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/features/arab/arabicRequiredLigatures.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
import { ContextParams } from '../../tokenizer.js';
import applySubstitution from '../applySubstitution.js';

// @TODO: use commonFeatureUtils.js for reduction of code duplication
// once #564 has been merged.

/**
* Update context params
* @param {any} tokens a list of tokens
Expand Down
3 changes: 3 additions & 0 deletions src/features/latn/latinLigatures.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
import { ContextParams } from '../../tokenizer.js';
import applySubstitution from '../applySubstitution.js';

// @TODO: use commonFeatureUtils.js for reduction of code duplication
// once #564 has been merged.

/**
* Update context params
* @param {any} tokens a list of tokens
Expand Down
6 changes: 3 additions & 3 deletions src/tables/gvar.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
// The `gvar` table stores information on how to modify glyf outlines across the variation space
// https://learn.microsoft.com/en-us/typography/opentype/spec/gvar

// import check from '../check';
// import parse from '../parse';
// import table from '../table';
// import check from '../check.js';
// import parse from '../parse.js';
// import table from '../table.js';

function makeGvarTable() {
console.warn('Writing of gvar tables is not yet supported.');
Expand Down
4 changes: 2 additions & 2 deletions test/tables/avar.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import assert from 'assert';
import { hex, unhex } from '../testutil';
import avar from '../../src/tables/avar';
import { hex, unhex } from '../testutil.js';
import avar from '../../src/tables/avar.js';

describe('tables/avar.js', function() {
const fvar = {axes: [
Expand Down
4 changes: 2 additions & 2 deletions test/tables/stat.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import assert from 'assert';
import { hex, unhex } from '../testutil';
import STAT from '../../src/tables/stat';
import { hex, unhex } from '../testutil.js';
import STAT from '../../src/tables/stat.js';

describe('tables/stat.js', function() {
// Style Attributes Header, v1.2
Expand Down