better browser/node detection #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Connum
added
the
dev
This was referenced Nov 28, 2023
Connum
added a commit
to Connum/opentype.js-next
that referenced
this pull request
Nov 28, 2023
ILOVEPIE
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Made browser/node context detection more reliable, so we'll pick the correct loading methods even when running in a WebWorker context.
Motivation and Context
close #174
How Has This Been Tested?
Can't really add a test for this, but checked that our tests (= Node) and docs (= Browser) still work
Types of changes
Checklist:
npm run testand all tests passed green (including code styling checks).