Bug fix for #757 - write all name table entries for fonts crafted from scratch #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `for...in` loop iterates over keys in `names` object, not indexes of an array of strings - if `uniqueID` or `postScriptName` is found to be missing, update the platform that is currently being looped over, not just the `unicode` platform.
Test now checks for defaults for `postScriptName` and also `uniqueID` Generating a `uniqueID` now provides a fallback empty string if no `manufacturer` exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to a change in 858a5d2, fonts that are created from scratch are not generating two default name table entries, which is causing fonts to be un-openable in Windows.
Lots of details captured in #757 - but here is a quick overview of the bug. The bug that was causing issues for two reasons:
for... inloop is looping over the keys of the array,0, 1, 2as opposed to the values of the array (which looks like what was intended).unicodevalue is updated as opposed to whatever platform is currently being looped over.Motivation and Context
Any font object generated programmatically would successfully export, but the font file itself would not be able to be opened. In Windows the "This is not a valid font file" dialog would be shown.
How Has This Been Tested?
Lots of tests explained in #757
Screenshots (if appropriate):
Types of changes
Checklist:
npm run testand all tests passed green (including code styling checks).