-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dns/bind: allow to specify primaryip's port for secondary zone #4445
base: master
Are you sure you want to change the base?
Conversation
<primaryip type="NetworkField"> | ||
<FieldSeparator>,</FieldSeparator> | ||
<asList>Y</asList> | ||
<primaryip type="CSVListField"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I know we have an address/port field type nowadays.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a IPPortField
field type. This type would require to specify a port and would therefore invalidate address only entries from previous versions...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it needs to be extended. My point is no more CSV magic regarding this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see your point, but I would argue that should be a separate issue/task, requiring changes in core. A quick github search for type="CSVListField"
shows matches in three files in core and 29 files in plugins. Can we move this forward in the meantime? Changing it to an extended IPPortField
later should be easy enough. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m only saying I’m not at the office until tomorrow to do core changes. Copy+paste is not the best idea here in 2025 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any updates on this? By now you must have arrived in the office. 😉
Closes: #4444
Notes on proposed solution
Bind/Domain.xml:
Bind/named.conf