Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

various mods to update speech select ai and ai holograms #48

Merged
merged 16 commits into from
Feb 4, 2025
Merged

various mods to update speech select ai and ai holograms #48

merged 16 commits into from
Feb 4, 2025

Conversation

paulparkinson
Copy link
Collaborator

No description provided.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Feb 2, 2025
jasperan
jasperan reviewed Feb 3, 2025
View reviewed changes
interactive-ai-holograms/ssl/cert.pem
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a certificate, if you consider it private, can you hide this file?

jasperan
jasperan reviewed Feb 3, 2025
View reviewed changes
interactive-ai-holograms/ssl/key.pem
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here too

jasperan
jasperan reviewed Feb 3, 2025
View reviewed changes
interactive-ai-holograms/ssl/localhost-key.pem
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here too

jasperan
jasperan reviewed Feb 3, 2025
View reviewed changes
interactive-ai-holograms/ssl/localhost.pem
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here too

jasperan
jasperan reviewed Feb 3, 2025
View reviewed changes
Copy link
Member

@jasperan jasperan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulparkinson can you take a look at the comments? I'll approve if everything is fine

@paulparkinson
Copy link
Collaborator Author

@paulparkinson can you take a look at the comments? I'll approve if everything is fine

Thanks @jasperan Yes, I know what you mean and was debating but since they are just for SSL self-signed certs, I figure they are ok to include for convenience/examples.

@jasperan jasperan merged commit f34cfb8 into oracle-devrel:main Feb 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasperan jasperan jasperan approved these changes

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulparkinson @jasperan