fix: check for regex in external (#573)

Co-authored-by: Juan Díaz <[email protected]>
originjs · Feb 18, 2024 · 7e5be49 · 7e5be49
1 parent 0a09bf0
commit 7e5be49
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/packages/lib/src/prod/shared-production.ts b/packages/lib/src/prod/shared-production.ts
@@ -46,11 +46,13 @@ export function prodSharedPlugin(
 
       if (shareName2Prop.size) {
         // remove item which is both in external and shared
-        inputOptions.external = (inputOptions.external as [])?.filter(
-          (item) => {
-            return !shareName2Prop.has(removeNonRegLetter(item, NAME_CHAR_REG))
-          }
-        )
+        inputOptions.external = (
+          inputOptions.external as (string | RegExp)[]
+        )?.filter((item) => {
+          if (item instanceof RegExp)
+            return ![...shareName2Prop.keys()].some((key) => item.test(key))
+          return !shareName2Prop.has(removeNonRegLetter(item, NAME_CHAR_REG))
+        })
       }
       return inputOptions
     },