Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct multiple instances of 'stragegy' typo #3906

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

7riatsu
Copy link
Contributor

@7riatsu 7riatsu commented Dec 11, 2024

This commit addresses several occurrences where 'strategy' was misspelled as 'stragegy' throughout the codebase.

Additionally, a similar issue was found and corrected in the Ory documentation repository (ory/docs), with a corresponding pull request submitted.

Related PR: ory/docs#1966

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@7riatsu
Copy link
Contributor Author

7riatsu commented Feb 18, 2025

This PR addresses several instances of the typo 'stragegy' corrected to 'strategy' to improve code readability and maintain consistency.
Could someone please review this when time permits?
If there are any concerns or if such changes are not aligned with the project's current priorities, please let me know.

@alnr alnr force-pushed the fix-typo-strategy branch from 4c1d4a3 to 6c51c47 Compare February 19, 2025 17:30
@alnr alnr requested a review from a team as a code owner February 19, 2025 17:30
@alnr alnr enabled auto-merge February 19, 2025 17:31
@alnr alnr added this pull request to the merge queue Feb 19, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 19, 2025
@alnr alnr force-pushed the fix-typo-strategy branch from 6c51c47 to f6da576 Compare February 20, 2025 09:14
@alnr alnr enabled auto-merge February 20, 2025 09:14
@alnr alnr added this pull request to the merge queue Feb 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 20, 2025
@alnr
Copy link
Contributor

alnr commented Feb 20, 2025

Hey @7riatsu . We had some issues with the merge queue and so couldn't merge this.

Would you mind re-running make sdk and force-pushing?

This commit addresses several occurrences where 'strategy' was misspelled as 'stragegy' throughout the codebase.

Additionally, a similar issue was found and corrected in the Ory documentation repository (ory/docs), with a corresponding pull request submitted.
@7riatsu
Copy link
Contributor Author

7riatsu commented Feb 21, 2025

I have addressed the feedback and force-pushed the changes.
Please review them at your convenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants