feat: faster OIDC front/back-channel logout #3937
Open
+110
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alnr
force-pushed
the
alnr/faster-oidc-logout
branch
2 times, most recently
from
3a5ad64 to
c0b6da1
Compare
alnr
force-pushed
the
alnr/faster-oidc-logout
branch
from
c0b6da1 to
aa1ee32
Compare
zepatrik
requested changes
Feb 7, 2025
|
|
||
| q = fmt.Sprintf(` | ||
| SELECT %s FROM %s c | ||
| WHERE id IN ( |
There was a problem hiding this comment.
I think WHERE EXISTS would be more performant here as the DB doesn't need to materialize the full sub query result.
There was a problem hiding this comment.
I am looking at some query plans. WHERE EXISTS does some wild stuff. Might have to tinker a bit more to get this perfect. It's looking like the subselect will be easier to optimize, though.
| p.NetworkID(ctx), | ||
| ).All(&cs); err != nil { | ||
| return nil, sqlcon.HandleError(err) | ||
| for _, c := range cs { |
There was a problem hiding this comment.
Avoid repeated allocations here.
Suggested change
| for _, c := range cs { | |
| withFrontChannelURL, withBackChannelURL = make([]client.Client, 0, len(cs)), make([]client.Client, 0, len(cs)) | |
| for _, c := range cs { |
There was a problem hiding this comment.
We don't know how many of each we will have, though. So this will almost always over allocate. Let's keep it simple :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/ory-corp/cloud/issues/7053