Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROS2 enable replay auto start #421

Merged
merged 1 commit into from
Jan 23, 2025
Merged

ROS2 enable replay auto start #421

merged 1 commit into from
Jan 23, 2025

Conversation

Samahu
Copy link
Contributor

@Samahu Samahu commented Jan 23, 2025 •
edited
Loading

Related Issues & PRs

Summary of Changes

  • Avoid the need to use execute commands by enabling auto_start similar to the os_pcap node.

Validation

The launch file works with no issues

ros2 ouster_ros replay.launch bag_file:=<...>

@Samahu Samahu added the enhancement New feature or request label Jan 23, 2025
@Samahu Samahu self-assigned this Jan 23, 2025
@Samahu Samahu marked this pull request as ready for review January 23, 2025 00:36
@Samahu Samahu changed the title ROS enable replay auto start ROS2 enable replay auto start Jan 23, 2025
@Samahu Samahu merged commit 65a1657 into ros2 Jan 23, 2025
10 checks passed
@Samahu Samahu deleted the ros2-enable-replay-auto-start branch January 23, 2025 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthew-lidar matthew-lidar matthew-lidar approved these changes

@twslankard twslankard Awaiting requested review from twslankard

@celentes celentes Awaiting requested review from celentes

@chrisbayruns chrisbayruns Awaiting requested review from chrisbayruns

@akatumalla-ouster akatumalla-ouster Awaiting requested review from akatumalla-ouster

@diego-guridi diego-guridi Awaiting requested review from diego-guridi

Assignees

@Samahu Samahu

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Samahu @matthew-lidar