Prometheus for database

[lpatte]

Description

Add resource to manage Prometheus for Databases Services

Type of change

Please delete options that are not relevant.

• New feature (non-breaking change which adds functionality)
• Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Test A: make testacc TESTARGS="-run TestAccCloudProjectDatabaseMongodbPrometheusDataSource_basic"
• Test B: make testacc TESTARGS="-run TestAccCloudProjectDatabasePrometheusDataSource_basic"
• Test C: make testacc TESTARGS="-run TestAccCloudProjectDatabasePrometheus_importBasic"
• Test D: make testacc TESTARGS="-run TestAccCloudProjectDatabaseMongodbPrometheus_basic"
• Test E: make testacc TESTARGS="-run TestAccCloudProjectDatabasePrometheus_basic"

Test Configuration:

• Existing HCL configuration you used:

resource "ovh_cloud_project_database_prometheus" "prom2" {
    service_name = "e55487da3ae846d7bd17bae8011fd4f8"
    engine       = "postgresql"
    cluster_id   = "xxxxxxxxxxxx"
    password_reset = "poto5"
} 

output "password2" {
    value = ovh_cloud_project_database_prometheus.prom2.password
    sensitive  = true
}

data "ovh_cloud_project_database_prometheus" "prom2" {
    service_name = "xxxxxxxxxxxx"
    engine       = "postgresql"
    cluster_id   = ovh_cloud_project_database_prometheus.prom2.cluster_id
}

resource "ovh_cloud_project_database_mongodb_prometheus" "prom" {
    service_name = "xxxxxxxxxxxx"
    cluster_id   = "xxxxxxxxxxxx"
    password_reset = "poto3"
}

output "password" {
    value = ovh_cloud_project_database_mongodb_prometheus.prom.password
    sensitive  = true
}

data "ovh_cloud_project_database_mongodb_prometheus" "prom" {
    service_name = "xxxxxxxxxxxx"
    cluster_id   = ovh_cloud_project_database_mongodb_prometheus.prom.cluster_id
}

[lpatte]

Waiting some backend devs on this feature to test with last version of the feature before merge this PR

[lpatte]

Backend development finished and resources tested with

[amstuta]

Suggested change

	EnablePrometheus bool `json:"EnablePrometheus"`
	EnablePrometheus bool `json:"enablePrometheus"`

[amstuta]

Suggested change

//log.Printf("[DEBUG] Will create pro: %+v for cluster %s from project %s", params, clusterId, serviceName)

[amstuta]

I would really prefer a bool property here as it will be way clearer for the end user. I understand that it requires him to input true on a first apply and then set the field to false to avoid re-resetting his password, but I think it's better this way

[lpatte]

No, it's not how terraform is use, we cannot ask our user to change the resource between the first and second apply. The user must be able to aply 5 time his code without update if he do not change the code.
We use the same strategy for user resources, and for all theses resources the documentation explain how to use it.
Our customers already use it without issue.

[rbeuque74]

What about password_reset_last_request_date with datetime format ?
That would be clearer IMO

[rbeuque74]

Agree with @amstuta that string is clearly not the way to go.

[lpatte]

Force datetime format is possible but in fact it's just a string with validate function (https://developer.hashicorp.com/terraform/plugin/sdkv2/schemas/schema-types#date-time-data).
It's just a trigger attribute with this documentation :

• password_reset - (Optional) Arbitrary string to change to trigger a password update. Use the terraform refresh command after executing terraform apply to update the output with the new password.

From my point of view, add a validate function will just add complexity for the user.
Also, if I change it here I have to change it in user resources and that will be a kind of breaking change.

[amstuta]

Suggested change

[amstuta]

optional, but maybe you could add something like for mongodb, please use the other datasource ...

[rbeuque74]

Change type datetime