Add a runtime for server logic #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfackler
commented
Jul 7, 2023
| fn endpoints(&self) -> #vec<#box_<dyn conjure_http::server::#endpoint_name<I, O> + Sync + Send>> | ||
| fn endpoints( | ||
| &self, | ||
| _: &conjure_http::private::Arc<conjure_http::server::ConjureRuntime>, |
There was a problem hiding this comment.
Conjure-generated server logic just ignores the runtime for now. When #245 is implemented it'll be able to take advantage of the runtime as well.
sfackler
commented
Jul 7, 2023
| where | ||
| I: IntoIterator, | ||
| I::Item: AsRef<str>; | ||
| } | ||
|
|
||
| /// A decoder which converts a single value using its [`FromStr`] implementation. | ||
| pub enum FromStrDecoder {} | ||
| pub struct FromStrDecoder<'a> { |
There was a problem hiding this comment.
Not sure if we'd ever want to pull dynamic logic for this kind of thing but I'm future proofing just in case.
|
I'll be doing the same thing for clients in a separate PR. |
Generate changelog in
|
sfackler
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the
ConjureRuntimeis currently empty, it will enable us to support things like dynamic configuration of serializable encodings and custom request body limits.cc #182