remove HashableT in frame.pyi where possible #1104
Open
+34
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mypy
has finally put in the feature allowing asymmetric getters/setters. During the testing, they had an issue with our stubs regarding where we useHashableT
. See python/mypy#18510 (comment)This fixes that issue. Then once
mypy
1.16 i released, we can fix the tests for setting columns that have# type: ignore
in it.