Add missing events to nomination pool extrinsincs #7377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockbmb
added
T1-FRAME
Ank4n
approved these changes
Jan 31, 2025
| /// A pool member's claim permission has been updated. | ||
| MemberClaimPermissionUpdated { member: T::AccountId, permission: ClaimPermission }, | ||
| /// A pool's metadata was updated. | ||
| MetadataUpdated { pool_id: PoolId, caller: T::AccountId }, |
There was a problem hiding this comment.
Is adding caller useful here? Nothing against it, just trying to understand the rationale. Same for other events.
There was a problem hiding this comment.
In the case of set_metadata, both the pool's root and its bouncer can make that call - this is to disambiguate which did it, in case the two roles are performed by different accounts.
The same goes for the other calls: nominate/chill can be called by the pool's root/nominator.
kianenigma
approved these changes
Feb 4, 2025
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found via open-web3-stack/polkadot-ecosystem-tests#165.
Closes #7370 .
Description
Some extrinsics from
pallet_nomination_poolswere not emitting events:set_configsset_claim_permissionset_metadatachillnominateIntegration
N/A
Review Notes
N/A