Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

299#make leaves to be placeholders #307

Merged
merged 3 commits into from
Sep 23, 2023

Conversation

tlapusan
Copy link
Collaborator

Continuing the work from #299 .

Also related to #305

Tyrion and others added 3 commits June 1, 2023 09:39
….18+

Update README.md; 
Add adapted win10 example for graphviz interface v0.18+ .

Signed-off-by: Tyrion <[email protected]>
…fixes the bug of graphviz erroring out due to file not found)
@tlapusan tlapusan requested a review from parrt September 23, 2023 13:47
@parrt
Copy link
Owner

parrt commented Sep 23, 2023

Do we need to merge #299 first?

@parrt parrt added bug Something isn't working clean up labels Sep 23, 2023
@tlapusan
Copy link
Collaborator Author

Do we need to merge #299 first?

no, I included that commit from #299 into this PR. After we are gonna merge this PR, we can close the 299..didn't managed how to add new commits to 299 PR..

@parrt parrt added this to the 2.2.3 milestone Sep 23, 2023
@parrt parrt merged commit 6b2d0ab into parrt:dev Sep 23, 2023
@tlapusan
Copy link
Collaborator Author

@parrt this feature was a pretty requested one. I think it will deserve a new release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working clean up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants