Fix crash on dual start #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lifezoned4
commented
Jul 26, 2023
test/libpax_test_cases.cpp
Outdated
| void test_no_unusual_reset(){ | ||
| const soc_reset_reason_t reason = esp_rom_get_reset_reason(0); | ||
| TEST_ASSERT_MESSAGE(reason != RESET_REASON_CPU0_SW, "Should not be software reset (lib crash?)"); | ||
| if(reason == RESET_REASON_CPU0_SW) TEST_ABORT(); |
There was a problem hiding this comment.
I am not 100% sure why the platformio testing framework (unity) is looping over the tests altough I try to abort them here. It still reaches the crash position and continue a rerun (fails on this one) but continue to loop.
This Unit Test construct can probably be cleaned up and been written in a better way.
lifezoned4
force-pushed
the
fix-dual-start-crash
branch
from
402e2a7 to
2ab70b1
Compare
mehtmehtsen
force-pushed
the
fix-dual-start-crash
branch
from
9d86e0c to
d98b9f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library crashes fatal when the start method is called twice.