PERF: delay preset loading for hutch-python #394
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
We want to defer preset loading for performance reasons.
This will fail tests until the corresponding pcdsdevices PR is merged.
How Has This Been Tested?
I was using this to test presets while developing pcdshub/pcdsdevices#1317
Where Has This Been Documented?
This PR
Left: Before, Right: After
![image](https://private-user-images.githubusercontent.com/35379409/403195291-23653982-f7b6-488f-b6c4-209b0999044b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1ODkwNzgsIm5iZiI6MTczOTU4ODc3OCwicGF0aCI6Ii8zNTM3OTQwOS80MDMxOTUyOTEtMjM2NTM5ODItZjdiNi00ODhmLWI2YzQtMjA5YjA5OTkwNDRiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDAzMDYxOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTUzMTdjNDRmZjMyZGYyNWE4MGVlN2NmODYwZTczN2NjN2IwYzJkNTVhMjFiMmEyODE2Y2RmNjM1NmQyZWU5MzUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.k7AXedZEZx0_yuGQ_j3q5a4PSSmFYgdi93u301_kpUs)
In getting that screenshot I ran into a variety of load times, preset deferral was always better but by varying margins.
Ran on a clone of XCS's hutch-python profile, copied into my dev area
Pre-merge checklist
docs/pre-release-notes.sh
and created a pre-release documentation page