Skip to content

Commit

Permalink
Temporarily increase Python benchmark timeout
Browse files Browse the repository at this point in the history
Increase the timeout of the Python benchmarks with `thread` progress
mode to avoid hitting rapidsai#15 . This
can be reverted once that issue is resolved.
  • Loading branch information
pentschev committed Apr 27, 2023
1 parent 1e463bb commit 0c1f101
Showing 1 changed file with 11 additions and 2 deletions.
13 changes: 11 additions & 2 deletions ci/test_python.sh
Original file line number Diff line number Diff line change
Expand Up @@ -58,13 +58,22 @@ run_py_benchmark() {
ASYNCIO_WAIT=""
fi

CMD_LINE="UCXPY_ENABLE_DELAYED_SUBMISSION=${ENABLE_DELAYED_SUBMISSION} UCXPY_ENABLE_PYTHON_FUTURE=${ENABLE_PYTHON_FUTURE} timeout 2m python -m ucxx.benchmarks.send_recv --backend ${BACKEND} -o cupy --reuse-alloc -n 8MiB --n-buffers $N_BUFFERS --progress-mode ${PROGRESS_MODE} ${ASYNCIO_WAIT}"
if [ $PROGRESS_MODE == "thread" ]; then
# Increased timeout to prevent issues from
# https://github.com/rapidsai/ucxx/issues/15 .
# TODO: keep the original 2m timeout when the issue above is resolved.
TIMEOUT=5m
else
TIMEOUT=2m
fi

CMD_LINE="UCXPY_ENABLE_DELAYED_SUBMISSION=${ENABLE_DELAYED_SUBMISSION} UCXPY_ENABLE_PYTHON_FUTURE=${ENABLE_PYTHON_FUTURE} timeout ${TIMEOUT} python -m ucxx.benchmarks.send_recv --backend ${BACKEND} -o cupy --reuse-alloc -n 8MiB --n-buffers $N_BUFFERS --progress-mode ${PROGRESS_MODE} ${ASYNCIO_WAIT}"

rapids-logger "Running: ${CMD_LINE}"
if [ $SLOW -ne 0 ]; then
rapids-logger "SLOW BENCHMARK: it may seem like a deadlock but will eventually complete."
fi
UCXPY_ENABLE_DELAYED_SUBMISSION=${ENABLE_DELAYED_SUBMISSION} UCXPY_ENABLE_PYTHON_FUTURE=${ENABLE_PYTHON_FUTURE} timeout 2m python -m ucxx.benchmarks.send_recv --backend ${BACKEND} -o cupy --reuse-alloc -n 8MiB --n-buffers $N_BUFFERS --progress-mode ${PROGRESS_MODE} ${ASYNCIO_WAIT}
UCXPY_ENABLE_DELAYED_SUBMISSION=${ENABLE_DELAYED_SUBMISSION} UCXPY_ENABLE_PYTHON_FUTURE=${ENABLE_PYTHON_FUTURE} timeout ${TIMEOUT} python -m ucxx.benchmarks.send_recv --backend ${BACKEND} -o cupy --reuse-alloc -n 8MiB --n-buffers $N_BUFFERS --progress-mode ${PROGRESS_MODE} ${ASYNCIO_WAIT}
}

rapids-logger "Downloading artifacts from previous jobs"
Expand Down

0 comments on commit 0c1f101

Please sign in to comment.