[WIP] Extended functionality of gopsutil #82
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid storing all procs, parse PID when killing the process
Exit proc gracefully and fix formatting
Paint row red on error in proc Also, changed row color to magenta when selected for killing
- renamed `paused` to `killSelected` - removed unnecessary once statement in updateProcs - if a process is selected for killing, check if the PID still exists on every update Fixed selection color not persisting
Press F to kill
* Toggle help window in procs page * Refactor to separate help message from widget * Use ui.List instead of ui.Block ui.List provides some styling and a simpler way to load data, as well as option to wrap lines, allowing easier resizing of the widget * Fix resizing of help widget * Add keybindings for main and `proc -pid` pages * Add help widget to `proc -pid` page * Add help widget to main page * Fix escape keybinding to clear screen first Escape was mapped to exiting the help screen, but the help menu would persist for a while on top of the page (until the next tick). This causes the redraw to happen immediately * Fix resizing issue * Fix formatting error * Add scroll in help menu, fix render delay Add scroll option for the help widget when all lines are not visible. Also fix the render delay when help widget is exited with <Esc> * Fix formatting and spacing issues * Fix procGraphs rendering * Remove unneccesary comment * Use slice of strings instead of string * Add kill keybind to help message * Remove unused module * Re-add scroll in help menu * Fix formatting issue
Added cute beaver and elephant ASCII Art
* GH-75: using after channel instead of delay so exit is immediate * GH-75 BUG exit time too slow - Using single select loop for generalStats. - Using select time.After instead of time.Delay for proc single and multiple. * GH-75: using ticker instead of after * GH-75: using common tick util for cpu info * GH-75: added license to tickutils.go
|
@MadhavJivrajani is this stale? Do I close it or does this have something we missed? |
|
Close it, the commits have diverged way too much, I was planning to refactor it a bit anyway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pscommand to get the scheduling policy assigned to a process.procfspackage to get the frequency of operation of each CPU.Partly solves #35
Type of change
Please delete options that are not relevant.
Checklist:
go fmton my code (reference)Note:
exportfeature, but separate issues pertaining to include them in the TUI should be created.gopsutillibrary #35