Add param out for propertyAccessor #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
commented
Mar 13, 2024
| @@ -15,7 +15,7 @@ | |||
| "require": { | |||
| "php": "^7.2 || ^8.0", | |||
| "ext-simplexml": "*", | |||
| "phpstan/phpstan": "^1.10.36" | |||
| "phpstan/phpstan": "^1.10.62" | |||
There was a problem hiding this comment.
For conditional phpstan-param-out
|
Thank you. |
herndlm
reviewed
Mar 18, 2024
| /** | ||
| * @phpstan-template T of object|array<mixed> | ||
| * @phpstan-param T &$objectOrArray | ||
| * @phpstan-param-out ($objectOrArray is object ? T : array<mixed>) $objectOrArray |
There was a problem hiding this comment.
hi, just for my understanding - this could be simply @phpstan-param-out T $objectOrArray as well, right?
I had a local stub with something like that and got an error when updating because of this PR -> could remove my local stub -> thx! :)
There was a problem hiding this comment.
@phpstan-template T of object|array<mixed>
@phpstan-param T &$objectOrArray
@phpstan-param-out T $objectOrArray
doesn't give the same beahvior
It fails
$array = [1 => 'ea'];
$propertyAccessor->setValue($array, 'foo', 'bar');
assertType('array', $array);
You'll get array{1: 'ea'} instead, which is wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting value to an object the object type does not change.
When setting value to an object, the array values change. But at least we know it's an array and not
array|object.