Skip to content

Commit

Permalink
len(thread) is cached anyway
Browse files Browse the repository at this point in the history
  • Loading branch information
nicovank committed Mar 19, 2024
1 parent 9e31de9 commit 8b3c3a1
Showing 1 changed file with 6 additions and 10 deletions.
16 changes: 6 additions & 10 deletions src/chatdbg/chatdbg_lldb.py
Original file line number Diff line number Diff line change
Expand Up @@ -611,7 +611,6 @@ def get_frame_summaries(
if not thread:
return None

total_frames = len(thread) # This can be a long operation e.g. stack overflow.
skipped = 0
summaries: List[Union[_FrameSummaryEntry, _SkippedFramesEntry]] = []

Expand Down Expand Up @@ -665,22 +664,19 @@ def get_frame_summaries(
[1 if isinstance(s, _FrameSummaryEntry) else s.count() for s in summaries]
)

if total_summary_count < total_frames:
if total_summary_count < len(thread):
if isinstance(summaries[-1], _SkippedFramesEntry):
summaries[-1] = _SkippedFramesEntry(
total_frames - total_summary_count + summaries[-1].count()
len(thread) - total_summary_count + summaries[-1].count()
)
else:
summaries.append(
_SkippedFramesEntry(total_frames - total_summary_count + 1)
)
summaries.append(_SkippedFramesEntry(len(thread) - total_summary_count + 1))
if len(summaries) > max_entries:
summaries.pop(-2)

assert (
sum([1 if isinstance(s, _FrameSummaryEntry) else s.count() for s in summaries])
== total_frames
)
assert sum(
[1 if isinstance(s, _FrameSummaryEntry) else s.count() for s in summaries]
) == len(thread)

return summaries

Expand Down

0 comments on commit 8b3c3a1

Please sign in to comment.