fix(pie chart): fix overlapping labels #2599
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Also issue #143 |
|
@calum-atkinson is it working as expected? If so, @plouc can you please do the review? |
|
This could be a solution, however I think it should be optional, if you compare this https://nivo-git-fork-raven-controls-fix-pie-cha-15a04b-ploucs-projects.vercel.app/pie/ to the current implementation https://nivo.rocks/pie/, and try a few different datasets, you'll see that it's not always better, and sometimes there are no overlaps to fix. Also it would be good to add some tests for this. |
|
@plouc do you have an example dataset it's worse with? |
|
@brian-codes, I just played with the deployed demo, and generated random dataset, see this screenshot for example: 
IMO, it would be better if labels were all the same and personally, I wouldn't want this behavior on by default. |
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
Fix based on the solution found in the following issue: #1378
Effectively, the solution recalculates the points on the label when segments of the pie are small (π/10 radians chosen as a useful value) so that more labels are able to be displayed without interference with one another.
It's not an exhaustive solution as when the segments become very small (<1% of the pie) there can still be overlapping, but this solution should improve the general case. A more complete solution may need an awareness of the neighbouring segments and the space around the pie.