chore: Fix new ruff lints #21040
Open
chore: Fix new ruff lints #21040
+2
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemanley
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
github-actions
bot
added
internal
MarcoGorelli
reviewed
Feb 1, 2025
| @@ -203,7 +203,6 @@ def __init__( | |||
| if register_globals: | |||
| for name, obj in _get_frame_locals( | |||
| all_compatible=False, | |||
| n_objects=None if (register_globals is True) else None, | |||
There was a problem hiding this comment.
😄 this made me smile
looks like n = None if register_globals is True else None was introduced in https://github.com/pola-rs/polars/pull/8749/files and then refactored in https://github.com/pola-rs/polars/pull/8762/files - @alexander-beedie do you happen to remember the intention behind it?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21040 +/- ##
==========================================
+ Coverage 79.21% 79.27% +0.06%
==========================================
Files 1583 1583
Lines 225545 225545
Branches 2586 2586
==========================================
+ Hits 178664 178809 +145
+ Misses 46291 46146 -145
Partials 590 590 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix new ruff lints failing in #21035