Upgrade googletest dependency #4592
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as it wasn't compiling with clang-18 on FreeBSD 14.2 anymore.
ponylang-main
added
the
discuss during sync
|
@mfelsche did you test this on FreeBSD? |
|
@SeanTAllen yes, successfully. On 14.2 amd64. I will look into the CI failure. |
Thanks. I assumed that was the case but wasn't completely certain. |
|
@mfelsche that failed test is one that is unfortunately sensitive to slow downs in the test environment. that appears to be the case in the failure you got. |
ponylang-main
removed
the
discuss during sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as it wasn't compiling with clang-18 on FreeBSD 14.2 anymore.
Let's see if CI thinks this is sufficient.