Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove layer shell proxy #337

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wash2
Copy link
Collaborator

@wash2 wash2 commented Jan 21, 2025

This removes support for layer shell in panel clients. I don't believe any applets need to create layer shell surfaces anymore. I'll double check that no other apps depend on layer shell before marking as ready.

This removes support for layer shell in panel clients. I don't believe any applets need to create layer shell surfaces anymore.
@wiiznokes
Copy link

Does it means we can't use layer shell in applet ? I was using it in my clipboard manager but it was buggy recently

@wash2
Copy link
Collaborator Author

wash2 commented Jan 22, 2025

Does it means we can't use layer shell in applet ? I was using it in my clipboard manager but it was buggy recently

Yeah, that would be a consequence of this change, or at least it would mean you have to do the layer shell surface differently. For example, you could set the WAYLAND_SOCKET variable to the value of the variable X_PRIVILEGED_WAYLAND_SOCKET given to your applet. Then you can spawn a daemon that works much like cosmic-osd, cosmic-launcher, cosmic-app-library, or cosmic-notifications, and can be activated easily with usage of the libcosmic single-instance feature. I don't think there is much benefit really to the panel acting as a proxy for layer shell, but maybe there is some use case where this method does not work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants