-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 2022_KumarScience_Xinjiang #252
base: master
Are you sure you want to change the base?
Conversation
Create 2022_KumarScience_Xinjiang.janno
I was able to download the genotype data for this package from a platform in China to which the author had uploaded it. |
Oookay, so I've gone through some of the review points. Some quick remarks on them:
|
So the one task left to do is fixing the relationships in terms of Poseidon_IDs. I think we need to make do this with a short script and some lookup table to exchange Alternative and Poseidon_IDs. @ainashch do you think you can perhaps just download the Janno file from this PR, work on this and send the fixed one back to me so I can included it? |
This is a take-over of #206 by @ainashch. A first review by @nevrome was:
Year_AuthorName_RelevantKeyword
. I propose2022_Kumar_Xinjiang
.n/a
.Relation_To
column works with theAlternative_IDs
, not thePoseidon_IDs
. Is there a reason why there are two sample naming schemes existing in parallel? Why did you opt for the alternative one for theRelation_To
column? I think there are multiple possible solutions to this.Relation_Degree
==first
+Relation_Type
==identical
to express that two samples are from the same individual. This is not necessary.Relation_Degree
can be set toidentical
directly.G218
- just to make sure: This is a proper site name?Site
set toUnknown
. I think it would be better to put it ton/a
.Date_Type
should be set tocontextual
for contextual ages.Date_Note
then does not need the redundant*Date contextual
(what does the*
mean?).Date_BC_AD_Median
can be computed as the mean ofDate_BC_AD_Start
andDate_BC_AD_Stop
for contextual ages.Publication
column is typically used for a bibtex key in a complete package. In this .janno-only submission we can leave it like it is for now.