Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move vsix package directory from /packages to /dist #1204

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

dotNomad
Copy link
Collaborator

This PR moves the location of the just vscode package output (the .vsix file) to the root /dist folder instead of using /packages.

This frees us the packages directory for npm workspaces which commonly use the packages directory.

See:

Intent

Part of #1035

Type of Change

    • Bug Fix
    • New Feature
    • Breaking Change
    • Documentation
    • Refactor
    • Tooling

Copy link
Collaborator

@tdstein tdstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I noticed while reviewing this that the entire archive workflow is no longer necessary. Everything that just archive touches could be removed.

.github/workflows/package.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/upload.yaml Outdated Show resolved Hide resolved
@dotNomad
Copy link
Collaborator Author

I noticed while reviewing this that the entire archive workflow is no longer necessary. Everything that just archive touches could be removed.

I'll do this as a follow-up PR.

@dotNomad dotNomad merged commit cb90854 into main Mar 27, 2024
19 checks passed
@dotNomad dotNomad deleted the dotnomad/package-to-dist branch March 27, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants