Implement support for viewing multiple profiles at once #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanriders
requested changes
Jan 31, 2025
stanriders
reviewed
Jan 31, 2025
PerformanceCalculatorGUI/Components/ExtendedCombinedProfileScore.cs
Outdated
Show resolved
Hide resolved
buyaspacecube
changed the title
Combined Profile screen
stanriders
requested changes
Jan 31, 2025
stanriders
requested changes
Jan 31, 2025
| { | ||
| usernameTextBox.FlashColour(Color4.Red, 1); | ||
| return; | ||
| } | ||
|
|
||
| Array.Clear(currentUsers); | ||
|
|
||
| string[] usernameArray = usernames.Split(',', StringSplitOptions.RemoveEmptyEntries | StringSplitOptions.TrimEntries); |
There was a problem hiding this comment.
I'd suggest doing splitting only when committing from the textbox, and changing calculateProfile() to accept an array
There was a problem hiding this comment.
good idea, i've done that and also renamed the method calculateProfiles so it makes more sense. i can revert that if necessary
|
feel free to change the placeholder names to whatever btw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes let you input a list of usernames and view their combined plays on one profile page, with each play showing the avatar of the user that set it. An option is included to only display the best play on each individual beatmap