Skip to content

Commit

Permalink
Remove unused service-account secret from 1b_secret (#412)
Browse files Browse the repository at this point in the history
Signed-off-by: Raj Babu Das <[email protected]>
  • Loading branch information
imrajdas authored Jul 30, 2020
1 parent 623686d commit e7f8c93
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 13 deletions.
4 changes: 0 additions & 4 deletions prombench/Makefile
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
INFRA_CMD ?= ../infra/infra

ifeq ($(AUTH_FILE),)
AUTH_FILE = /etc/serviceaccount/service-account.json
endif

.PHONY: deploy clean
deploy: nodepool_create resource_apply
# GCP sometimes takes longer than 30 tries when trying to delete nodepools
Expand Down
1 change: 0 additions & 1 deletion prombench/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ export GITHUB_REPO=prometheus
-v SERVICEACCOUNT_CLIENT_EMAIL:$SERVICEACCOUNT_CLIENT_EMAIL \
-v OAUTH_TOKEN="$(printf $OAUTH_TOKEN | base64 -w 0)" \
-v WH_SECRET="$(printf $WH_SECRET | base64 -w 0)" \
-v GKE_AUTH="$(cat $AUTH_FILE | base64 -w 0)" \
-v GITHUB_ORG:$GITHUB_ORG -v GITHUB_REPO:$GITHUB_REPO \
-f manifests/cluster-infra
```
Expand Down
8 changes: 0 additions & 8 deletions prombench/manifests/cluster-infra/1b_secrets.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,6 @@ data:
---
apiVersion: v1
kind: Secret
metadata:
name: service-account
type: Opaque
data:
service-account.json: "{{ .GKE_AUTH }}"
---
apiVersion: v1
kind: Secret
metadata:
name: whsecret
type: Opaque
Expand Down

0 comments on commit e7f8c93

Please sign in to comment.