SetMemoryMode syscall related changes #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update SetMemoryMode docs with new findings
|
Just curiosity Is this really PSX only? Isn't it applicable to namco system 256 since it also recycles the PSX EE+GS chip revision |
fjtrujy
reviewed
Jan 24, 2025
| @@ -52,7 +53,7 @@ void _libcglue_rtc_update() {} | |||
| // "weak" function called by crt0.o | |||
| void _ps2sdk_memory_init() | |||
| { | |||
| if (GetMemorySize() == (32 * 1024 * 1024) && IsDESRMachine() == 1) { | |||
| if (GetMemorySize() == (32 * 1024 * 1024) && GetSyscallHandler(__NR_GetMemoryMode) && GetMemoryMode() == 1) { | |||
There was a problem hiding this comment.
should we create a macro to make easier the usage of this GetSyscallHandler(__NR_GetMemoryMode) && GetMemoryMode() == 1? or even the whole if condition?
There was a problem hiding this comment.
It might be a good idea, but since it is in the sample I left it out of this PR for now
Yes, it is not applicable to System 256/148 or DTL-T due to missing relevant system calls |
fjtrujy
approved these changes
Jan 24, 2025
|
@rickgaiser any concern? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mainly avoids a fileio call at init