Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the missing REMOTE_TYPES property of NpmRepository class. #279

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Add the missing REMOTE_TYPES property of NpmRepository class. #279

merged 1 commit into from
Feb 11, 2025

Conversation

decko
Copy link
Member

@decko decko commented Feb 10, 2025

Closes #276

bmbouter
bmbouter previously approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@bmbouter bmbouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix and way to add a test and bootstrap the pytest bindings!

@decko decko requested a review from bmbouter February 10, 2025 21:47
@bmbouter bmbouter merged commit eb3c60c into pulp:main Feb 11, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmbouter bmbouter bmbouter approved these changes

Assignees
No one assigned
Labels
no-issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing REMOTE_TYPES on NpmRepository model
2 participants
@decko @bmbouter