Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-126835: Move optimization of constant sequence creation from codegen to CFG #129426

Merged
merged 16 commits into from
Feb 1, 2025

Conversation

Eclips4
Copy link
Member

@Eclips4 Eclips4 commented Jan 29, 2025

@Eclips4 Eclips4 marked this pull request as draft January 29, 2025 09:22
@Eclips4 Eclips4 marked this pull request as ready for review January 29, 2025 10:45
Python/flowgraph.c Outdated Show resolved Hide resolved
Python/flowgraph.c Outdated Show resolved Hide resolved
Python/flowgraph.c Outdated Show resolved Hide resolved
Python/flowgraph.c Outdated Show resolved Hide resolved
Python/flowgraph.c Outdated Show resolved Hide resolved
Python/flowgraph.c Outdated Show resolved Hide resolved
@Eclips4 Eclips4 requested a review from iritkatriel January 29, 2025 21:07
Python/flowgraph.c Outdated Show resolved Hide resolved
Python/flowgraph.c Outdated Show resolved Hide resolved
Python/flowgraph.c Outdated Show resolved Hide resolved
Python/flowgraph.c Outdated Show resolved Hide resolved
Python/flowgraph.c Show resolved Hide resolved
Copy link
Contributor

@WolframAlph WolframAlph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions, suggestions and nitpicks.

Python/flowgraph.c Outdated Show resolved Hide resolved
Python/flowgraph.c Outdated Show resolved Hide resolved
Python/flowgraph.c Outdated Show resolved Hide resolved
Python/flowgraph.c Outdated Show resolved Hide resolved
Python/flowgraph.c Outdated Show resolved Hide resolved
Python/flowgraph.c Outdated Show resolved Hide resolved
Python/flowgraph.c Show resolved Hide resolved
@Eclips4 Eclips4 requested a review from WolframAlph January 31, 2025 17:37
Copy link
Contributor

@WolframAlph WolframAlph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Python/flowgraph.c Outdated Show resolved Hide resolved
Copy link
Member

@iritkatriel iritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Eclips4 Eclips4 enabled auto-merge (squash) February 1, 2025 10:31
@Eclips4 Eclips4 merged commit 7d0521d into python:main Feb 1, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants