[3.13] gh-105704: Disallow square brackets ([ and ]) in domain names for parsed URLs (GH-129418)
#129526
+58
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es for parsed URLs (pythonGH-129418) * pythongh-105704: Disallow square brackets ( and ) in domain names for parsed URLs * Use Sphinx references Co-authored-by: Peter Bierma <[email protected]> * Add mismatched bracket test cases, fix news format * Add more test coverage for ports --------- (cherry picked from commit d89a5f6) Co-authored-by: Seth Michael Larson <[email protected]> Co-authored-by: Peter Bierma <[email protected]>
sethmlarson
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
urlparse does not flag hostname *containing* [ or ] as incorrect #105704: Disallow square brackets ( and ) in domain names for parsed URLs
Use Sphinx references
Co-authored-by: Peter Bierma [email protected]
Add mismatched bracket test cases, fix news format
Add more test coverage for ports
(cherry picked from commit d89a5f6)
Co-authored-by: Seth Michael Larson [email protected]
Co-authored-by: Peter Bierma [email protected]