gh-100239: replace BINARY_SUBSCR & family by BINARY_OP with oparg NB_SUBSCR #129700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
iritkatriel
commented
Feb 5, 2025
•
iritkatriel
commented
- Issue: Specialize long tail of binary operations using a table. #100239
iritkatriel
requested review from
Fidget-Spinner and
markshannon
as code owners
iritkatriel
force-pushed
the
binary_subscr_to_op
branch
from
ff0d788 to
d9b0d1b
Compare
iritkatriel
commented
Feb 5, 2025
| Py_DECREF(descriptor); | ||
| return SPEC_FAIL_OTHER; | ||
| } | ||
| } |
There was a problem hiding this comment.
There is quite a bit or repetition between this function and _Py_Specialize_BinaryOp. I would like to merge them into one function, but not sure it should be in this PR.
There was a problem hiding this comment.
Fix it in another PR.
I think it best to make the change in one PR and the refactoring in another.
markshannon
approved these changes
Feb 7, 2025
|
👍 The stats are as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.