Acknowledge network issues from GitHub #710
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We quite regularly get failures due to sporadic GitHub network issues. This change introduces handling of a new
cherry_picker.GitHubException
to automatically abort and recover a sane state of the repository.Previously, the repository was left in a PR_CREATING state, which was not expected by cherry-picker on a re-run, which made miss-islington stall until manually restarted.