Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acknowledge network issues from GitHub #710

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Acknowledge network issues from GitHub #710

merged 1 commit into from
Jan 15, 2025

Conversation

ambv
Copy link
Contributor

@ambv ambv commented Jan 15, 2025

We quite regularly get failures due to sporadic GitHub network issues. This change introduces handling of a new cherry_picker.GitHubException to automatically abort and recover a sane state of the repository.

Previously, the repository was left in a PR_CREATING state, which was not expected by cherry-picker on a re-run, which made miss-islington stall until manually restarted.

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (aa67b82) to head (ae39a68).

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #710   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          357       360    +3     
  Branches        14        14           
=========================================
+ Hits           357       360    +3     
Flag Coverage Δ
Python_3.11 100.00% <100.00%> (ø)
Python_3.12 100.00% <100.00%> (ø)
Python_3.13 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
miss_islington/delete_branch.py 100.00% <100.00%> (ø)

@ambv ambv merged commit f647d98 into main Jan 15, 2025
11 checks passed
@ambv ambv deleted the network-issues branch January 15, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant