Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disambiguate SPDXIDs when merging source and externals SBOMs #214

Merged
merged 3 commits into from
Feb 11, 2025
Merged

Disambiguate SPDXIDs when merging source and externals SBOMs #214

merged 3 commits into from
Feb 11, 2025
+41 −0

Conversation

sethmlarson
Copy link
Collaborator

@sethmlarson sethmlarson requested a review from hugovk February 10, 2025 21:35
@hugovk
Copy link
Member

hugovk commented Feb 10, 2025

CI is failing:

Would you like this in tomorrow's 3.14 alpha?

@sethmlarson
Copy link
Collaborator Author

Would you like this in tomorrow's 3.14 alpha?

I don't think it's a blocker, especially for an alpha. Thanks for the quick review, I'll get your comments addressed.

@hugovk
Copy link
Member

hugovk commented Feb 11, 2025

It's ready in time for the alpha, let's merge, thanks!

@hugovk hugovk merged commit 51b5905 into python:master Feb 11, 2025
12 checks passed
@sethmlarson sethmlarson deleted the spdx-id-collision branch February 11, 2025 14:29
@sethmlarson
Copy link
Collaborator Author

Thanks Hugo! 💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SBOM for Windows contains duplicate component IDs
2 participants
@sethmlarson @hugovk