Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pre-commit and fix zizmor's excessive-permissions warnings #217

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Feb 11, 2025

warning[excessive-permissions]: overly broad permissions
   --> .github/workflows/source-and-docs-release.yml:1:1
    |
  1 | / on:
  2 | |   push:
...   |
179 | |           cd ../installation
180 | |           ./bin/python3 -m test -uall
    | |______________________________________- default permissions used due to no permissions: block
    |
    = note: audit confidence → Medium

warning[excessive-permissions]: overly broad permissions
  --> .github/workflows/source-and-docs-release.yml:47:3
   |
47 | /   verify-input:
48 | |     runs-on: ubuntu-24.04
...  |
71 | |             exit 1
72 | |           fi
   | |            -
   | |____________|
   |              this job
   |              default permissions used due to no permissions: block
   |
   = note: audit confidence → Medium

warning[excessive-permissions]: overly broad permissions
   --> .github/workflows/source-and-docs-release.yml:74:3
    |
 74 | /   build-source:
 75 | |     runs-on: ubuntu-24.04
...   |
111 | |           path: |
112 | |             cpython/${{ env.CPYTHON_RELEASE }}/src
    | |                                                  -
    | |__________________________________________________|
    |                                                    this job
    |                                                    default permissions used due to no permissions: block
    |
    = note: audit confidence → Medium

warning[excessive-permissions]: overly broad permissions
   --> .github/workflows/source-and-docs-release.yml:114:3
    |
114 | /   build-docs:
115 | |     runs-on: ubuntu-24.04
...   |
154 | |           path: |
155 | |             Doc/dist/
    | |                     -
    | |_____________________|
    |                       this job
    |                       default permissions used due to no permissions: block
    |
    = note: audit confidence → Medium

warning[excessive-permissions]: overly broad permissions
   --> .github/workflows/source-and-docs-release.yml:157:3
    |
157 | /   test-source:
158 | |     runs-on: ubuntu-24.04
...   |
179 | |           cd ../installation
180 | |           ./bin/python3 -m test -uall
    | |                                      -
    | |______________________________________|
    |                                        this job
    |                                        default permissions used due to no permissions: block
    |
    = note: audit confidence → Medium

warning[excessive-permissions]: overly broad permissions
  --> .github/workflows/test.yml:9:3
   |
 9 | /   tests:
10 | |     name: "Tests"
...  |
33 | |         with:
34 | |           token: ${{ secrets.CODECOV_ORG_TOKEN }}
   | |                                                  -
   | |__________________________________________________|
   |                                                    this job
   |                                                    default permissions used due to no permissions: block
   |
   = note: audit confidence → Medium

11 findings (5 suppressed): 0 unknown, 0 informational, 0 low, 6 medium, 0 high

https://woodruffw.github.io/zizmor/audits/#excessive-permissions


Also remove the config for https://pre-commit.ci/ because we haven't enabled it for this repo, and perhaps we shouldn't, as we need to be extra careful with this one?

ci:	
  autoupdate_schedule: quarterly	

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant