Resolve __hfma2 intrinsic error by excluding unsupported Maxwell architecture in setup.py #1557
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to compile torchao from source for Hopper GPUs using
pip install -e .
, I encountered a build issue. nvcc version in my env is 12.6. The error occurs in torchao/csrc/cuda/sparse_marlin/mma.h:The issue arises because the __hfma2 intrinsic is not supported by the compute_52 (Maxwell) architecture, even though I am targeting the compute_90 (Hopper) architecture. It seems that we should explicitly specify the supported GPU architectures in setup.py to ensure compatibility with newer architectures. Here's the proposed update:
Looking forward to your feedback!