Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change TORCH_LIBRARY to TORCH_LIBRARY_FRAGMENT #1645

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

metascroy
Copy link
Contributor

This is to prevent conflicts between CPU/MPS because torch requires all ops be defined in same block.

Copy link

pytorch-bot bot commented Jan 30, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1645

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit d791cb9 with merge base c8eb8d3 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 30, 2025
@metascroy metascroy requested a review from kimishpatel January 30, 2025 19:06
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manuelcandales how do I test the change? Is there a script I should run?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cd ao/torchao/experimental/ops/mps
bash build.sh
python test/test_lowbit.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants